Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float64 != float causes Windows tests to fail randomly #112

Closed
rly opened this issue Jul 25, 2019 · 0 comments · Fixed by #113
Closed

float64 != float causes Windows tests to fail randomly #112

rly opened this issue Jul 25, 2019 · 0 comments · Fixed by #113
Labels
category: bug errors in the code or code behavior

Comments

@rly
Copy link
Contributor

rly commented Jul 25, 2019

See NeurodataWithoutBorders/pynwb#1015

Proposed workaround:
change the docval macro for 'scalar_data' from:

'scalar_data': [str, int, float]

to:

'scalar_data': [str, int, float, np.float64]

until a fix is released in a future version of h5py. The fix has already been pushed to their master branch, but it may be a while before it is released.
@rly rly added the category: bug errors in the code or code behavior label Jul 25, 2019
rly added a commit that referenced this issue Jul 25, 2019
@rly
Support np.float64 in rare cases when np.float64 != float. Fix #112
d31e475
@rly rly mentioned this issue Jul 25, 2019
Merged
@rly rly closed this as completed in #113 Jul 25, 2019
rly added a commit that referenced this issue Jul 25, 2019
@rly
Support np.float64 in rare cases when np.float64 != float. Fix #112 (#…
860e2ca 
…113)
rly added a commit that referenced this issue Aug 2, 2019
@rly
A better fix for #112
b9918f2
@rly rly mentioned this issue Aug 2, 2019
Merged
rly added a commit that referenced this issue Aug 2, 2019
@rly
A better fix for #112 (#127)
33dd45e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: bug errors in the code or code behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support np.float64 in rare cases when np.float64 != float hdmf-dev/hdmf
1 participant
@rly