Cache the spec by default when writing file #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. if the group '/specifications/core/2.0.2/' already contains the group 'nwb.base', do not try to create it again when caching the spec
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
=========================================
+ Coverage 66.65% 66.9% +0.24%
=========================================
Files 24 24
Lines 4814 4814
Branches 1092 1092
=========================================
+ Hits 3209 3221 +12
+ Misses 1234 1228 -6
+ Partials 371 365 -6
Continue to review full report at Codecov.
|
ajtritt
previously approved these changes
Jun 20, 2019
|
I forgot that @bendichter had already made a PR #63 on this. @ajtritt I now use |
5 tasks
ajtritt
approved these changes
Jun 20, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Also, prevent overwriting of spec with same name
e.g. if the group '/specifications/core/2.0.2/' already contains the group 'nwb.base', do not try to create it again when caching the spec.