Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external link within file on export #847

Merged
merged 6 commits into from
Apr 13, 2023
Merged

Fix external link within file on export #847

merged 6 commits into from
Apr 13, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 12, 2023

Motivation

Fix #846

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (f38e0b1) 87.81% compared to head (89e53c3) 87.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #847   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files          44       44           
  Lines        8959     8962    +3     
  Branches     2698     2699    +1     
=======================================
+ Hits         7867     7870    +3     
  Misses        779      779           
  Partials      313      313           
Impacted Files Coverage Δ
src/hdmf/backends/io.py 96.77% <75.00%> (+0.16%) ⬆️
src/hdmf/backends/hdf5/h5tools.py 82.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

oruebel
oruebel previously approved these changes Apr 12, 2023
@rly rly requested a review from oruebel April 12, 2023 22:37
@rly rly requested review from oruebel and removed request for oruebel April 13, 2023 20:00
@oruebel oruebel added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Apr 13, 2023
@oruebel oruebel added this to the Next Release milestone Apr 13, 2023
@rly rly merged commit 963aea7 into dev Apr 13, 2023
@rly rly deleted the fix/export_links branch April 13, 2023 22:02
@rly rly removed this from the 3.14.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Export sometimes creates external links to itself
2 participants