Fixes for boolean na types, typos, na assignments in test cases #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest changes
Update from base repo
…lean Thrift cast to prevent type error
… fix int64 test that was actually an in32 test, add int32 test case
jp-harvey
changed the title
|
LGTM |
randyzwitch
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options
jp-harvey
added a commit
to jp-harvey/pymapd
that referenced
this pull request
Nov 15, 2018
* Fixes for boolean na types, typos, na assignments in test cases (heavyai#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (heavyai#117) * Fixes for boolean na types, typos, na assignments in test cases (heavyai#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options
randyzwitch
pushed a commit
that referenced
this pull request
Nov 28, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns]
randyzwitch
pushed a commit
that referenced
this pull request
Nov 28, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns] * Convert numpy.ndarray to list * Clarify confusing condition
randyzwitch
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns] * Convert numpy.ndarray to list * Clarify confusing condition * Fix fillna dictionary vaules for FLOAT and DOUBLE * Fix tests
randyzwitch
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * [WIP] initial changes for matching col types * Convert to int for DATE types * Revert "Convert to int for DATE types" This reverts commit 04d4a6e. * Revert "Revert "Convert to int for DATE types"" This reverts commit 4f2b2ee. * Fix nulls and timestamp type * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns] * Convert numpy.ndarray to list * Clarify confusing condition * Fix fillna dictionary vaules for FLOAT and DOUBLE * Remove cruft * Nans fixes * Add na type for DECIMAL * Fix flake8 issues * Add support for decimals * Fix whitespace * Remove extraneous whitespace
randyzwitch
pushed a commit
that referenced
this pull request
Dec 3, 2018
…es in load_table_columnar (#129) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * [WIP] initial changes for matching col types * Convert to int for DATE types * Revert "Convert to int for DATE types" This reverts commit 04d4a6e. * Revert "Revert "Convert to int for DATE types"" This reverts commit 4f2b2ee. * Fix nulls and timestamp type * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns] * Convert numpy.ndarray to list * Clarify confusing condition * Fix fillna dictionary vaules for FLOAT and DOUBLE * Remove cruft * Nans fixes * Add na type for DECIMAL * Fix flake8 issues * Add ability to load based on matching table column names to dataframe column names * Add support for decimals * Fix whitespace * Remove extraneous whitespace * Make load from table schema mandatory, dataframe column length validation
randyzwitch
pushed a commit
that referenced
this pull request
Dec 5, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * [WIP] initial changes for matching col types * Convert to int for DATE types * Revert "Convert to int for DATE types" This reverts commit 04d4a6e. * Revert "Revert "Convert to int for DATE types"" This reverts commit 4f2b2ee. * Fix nulls and timestamp type * Fix out of bounds date errors on date conversion * Update date test to fall outside bounds of datetime64[ns] * Convert numpy.ndarray to list * Clarify confusing condition * Fix fillna dictionary vaules for FLOAT and DOUBLE * Remove cruft * Nans fixes * Add na type for DECIMAL * Fix flake8 issues * Add ability to load based on matching table column names to dataframe column names * Add support for decimals * Fix whitespace * Remove extraneous whitespace * Make load from table schema mandatory, dataframe column length validation * Convert dataframe to array if loading rowwise
randyzwitch
pushed a commit
that referenced
this pull request
Dec 17, 2018
…ther OmniSci client interfaces (#138) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Convert strings to datetime64[ns] if the column type is timestamp, or return int if int passed * Handle pd datetime types with a timezone * Fix typo * Fix erroneous fix.
randyzwitch
pushed a commit
that referenced
this pull request
Aug 1, 2019
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Add binary encryption support * Add parameters to _part_uri * Removed certfile and keyfile since they are not related to binary encryption, made names more meaningful * Add and update tests * Fix find and replace silliness * Fix incorrect param names * Fix packaging issue * Fix indentation
andrewseidl
pushed a commit
that referenced
this pull request
Apr 29, 2020
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Sync from source repo master (#4) * Fixes for boolean na types, typos, na assignments in test cases (#110) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Option to chunk Pandas columnar data load (#117) * Fixes for boolean na types, typos, na assignments in test cases (#110) (#3) * Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error * Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case * Fix linting issue * Add option for chunking a Pandas columnar data load * Fix linting issues * Reorder options * Reorder options * Add ability to authenticate via SAML * Update dependencies * Add ability to authenticate via SAML Update dependencies * Add numba as a requirement * fixup: remove incorrect docstring Co-authored-by: JP <jpharvey@omnisci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.