Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for boolean na types, typos, na assignments in test cases #110

Merged
merged 5 commits into from
Nov 12, 2018

Conversation

jp-harvey
Copy link
Contributor

No description provided.

jp-harvey and others added 4 commits October 29, 2018 10:29
… fix int64 test that was actually an in32 test, add int32 test case
@jp-harvey jp-harvey changed the title Fixes for boolean na types, typos, incorrect na assignments in test cases Fixes for boolean na types, typos, na assignments in test cases Nov 10, 2018
@randyzwitch
Copy link
Contributor

LGTM

@randyzwitch randyzwitch merged commit a0feb21 into heavyai:master Nov 12, 2018
jp-harvey added a commit to jp-harvey/pymapd that referenced this pull request Nov 13, 2018
…yai#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue
randyzwitch pushed a commit that referenced this pull request Nov 15, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options
jp-harvey added a commit to jp-harvey/pymapd that referenced this pull request Nov 15, 2018
* Fixes for boolean na types, typos, na assignments in test cases (heavyai#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (heavyai#117)

* Fixes for boolean na types, typos, na assignments in test cases (heavyai#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options
randyzwitch pushed a commit that referenced this pull request Nov 28, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]
randyzwitch pushed a commit that referenced this pull request Nov 28, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]

* Convert numpy.ndarray to list

* Clarify confusing condition
randyzwitch pushed a commit that referenced this pull request Nov 29, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]

* Convert numpy.ndarray to list

* Clarify confusing condition

* Fix fillna dictionary vaules for FLOAT and DOUBLE

* Fix tests
randyzwitch pushed a commit that referenced this pull request Nov 29, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* [WIP] initial changes for matching col types

* Convert to int for DATE types

* Revert "Convert to int for DATE types"

This reverts commit 04d4a6e.

* Revert "Revert "Convert to int for DATE types""

This reverts commit 4f2b2ee.

* Fix nulls and timestamp type

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]

* Convert numpy.ndarray to list

* Clarify confusing condition

* Fix fillna dictionary vaules for FLOAT and DOUBLE

* Remove cruft

* Nans fixes

* Add na type for DECIMAL

* Fix flake8 issues

* Add support for decimals

* Fix whitespace

* Remove extraneous whitespace
randyzwitch pushed a commit that referenced this pull request Dec 3, 2018
…es in load_table_columnar (#129)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* [WIP] initial changes for matching col types

* Convert to int for DATE types

* Revert "Convert to int for DATE types"

This reverts commit 04d4a6e.

* Revert "Revert "Convert to int for DATE types""

This reverts commit 4f2b2ee.

* Fix nulls and timestamp type

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]

* Convert numpy.ndarray to list

* Clarify confusing condition

* Fix fillna dictionary vaules for FLOAT and DOUBLE

* Remove cruft

* Nans fixes

* Add na type for DECIMAL

* Fix flake8 issues

* Add ability to load based on matching table column names to dataframe column names

* Add support for decimals

* Fix whitespace

* Remove extraneous whitespace

* Make load from table schema mandatory, dataframe column length validation
randyzwitch pushed a commit that referenced this pull request Dec 5, 2018
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* [WIP] initial changes for matching col types

* Convert to int for DATE types

* Revert "Convert to int for DATE types"

This reverts commit 04d4a6e.

* Revert "Revert "Convert to int for DATE types""

This reverts commit 4f2b2ee.

* Fix nulls and timestamp type

* Fix out of bounds date errors on date conversion

* Update date test to fall outside bounds of datetime64[ns]

* Convert numpy.ndarray to list

* Clarify confusing condition

* Fix fillna dictionary vaules for FLOAT and DOUBLE

* Remove cruft

* Nans fixes

* Add na type for DECIMAL

* Fix flake8 issues

* Add ability to load based on matching table column names to dataframe column names

* Add support for decimals

* Fix whitespace

* Remove extraneous whitespace

* Make load from table schema mandatory, dataframe column length validation

* Convert dataframe to array if loading rowwise
randyzwitch pushed a commit that referenced this pull request Dec 17, 2018
…ther OmniSci client interfaces (#138)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Convert strings to datetime64[ns] if the column type is timestamp, or return int if int passed

* Handle pd datetime types with a timezone

* Fix typo

* Fix erroneous fix.
randyzwitch pushed a commit that referenced this pull request Aug 1, 2019
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Add binary encryption support

* Add parameters to _part_uri

* Removed certfile and keyfile since they are not related to binary encryption, made names more meaningful

* Add and update tests

* Fix find and replace silliness

* Fix incorrect param names

* Fix packaging issue

* Fix indentation
andrewseidl pushed a commit that referenced this pull request Apr 29, 2020
* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Sync from source repo master (#4)

* Fixes for boolean na types, typos, na assignments in test cases (#110)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Option to chunk Pandas columnar data load (#117)

* Fixes for boolean na types, typos, na assignments in test cases (#110) (#3)

* Fix na types for boolean, fix test case na types, fillna prior to boolean Thrift cast to prevent type error

* Attempt to distinguish int from bigint when int column contains None, fix int64 test that was actually an in32 test, add int32 test case

* Fix linting issue

* Add option for chunking a Pandas columnar data load

* Fix linting issues

* Reorder options

* Reorder options

* Add ability to authenticate via SAML

* Update dependencies

* Add ability to authenticate via SAML

Update dependencies

* Add numba as a requirement

* fixup: remove incorrect docstring

Co-authored-by: JP <jpharvey@omnisci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants