Add timestamp precision support in Parser #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wamsiv
force-pushed
the
wam/ts_precisions
branch
from
6e23679
to
212be52
Compare
wamsiv
changed the title
|
Here is a working example for the parser support: https://gist.github.com/wamsiv/49e17917742c2e8d581806f98e591987 |
andrewseidl
approved these changes
Mar 13, 2019
pymapd/_utils.py
Outdated
| return base + datetime.timedelta(seconds=epoch) | ||
| elif precision == 3: | ||
| modulus = epoch % 1000 | ||
| seconds = epoch / 1000 |
There was a problem hiding this comment.
Could use divmod() here to get both at the same time, though would have to see if the numbers we're working with are large enough for that to be faster than the current method.
There was a problem hiding this comment.
divmod() is working well with large numbers, I have used it in code. Thanks!
|
Added a note in docs regarding WIP timestamp nanosecond support in pymapd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170