Update Thrift to 4.8 with namespacing #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
randyzwitch
changed the title
andrewseidl
added a commit
to heavyai/heavydb
that referenced
this pull request
Jul 23, 2019
Previously our generated code ended up in the top-level namespace, which would cause issues if other packages also happened to have similarly named modules (like `common`). Now all generated modules are placed in an OmniSci-specific namespace. cc: heavyai/pymapd#252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing namespacing in Thrift definition files for python, to avoid copying so many separate libraries into a user namespace.