cmake: Replace genbuild.sh with GenerateBuildInfo.cmake
#54
Conversation
No need to test non-CMake stuff in this branch.
Add CI test for `obj/build.h` generation.
|
Friendly ping @fanquake @theuni @TheCharlatan @vasild @pablomartin4btc :) |
There was a problem hiding this comment.
tACK 2e2a7b5
Built on Ubuntu 22.04, ran ctest, functionals and executed bitcoind -signet up to full headers sync.
|
Light ACK, why not remove |
Sure. After transition to CMake is completed? Right now it seems useful to keep it to ensure that |
There was a problem hiding this comment.
tACK 2e2a7b5
Built cross-compiled for Windows on WSL Ubuntu 22.04 (instructions), binaries are fine and ran on Windows 11 Pro but 2 tests are failing running ctest, I've verified that's also happening on cmake-staging branch, so I've opened #55.
Going to merge this PR shortly to unlock Windows builds. |
This PR replaces shell
share/genbuild.shscript with CMakeGenerateBuildInfo.cmakescript, which works on all platforms, including Windows.Fixes build on Windows after #51.
Please note, that in the master branch, MSVC builds lack build info entirely.
Added a CI test to ensure equivalence of the script replacement.