Revamp issue handling #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to issue handling:
BidsIssue
has been merged intoBidsHedIssue
, and most of the combined class's fields have been renamed.IssueError
as a shortcut for throwing internal errors.Error
s have been converted toIssueError
s.internalConsistencyError
has been merged intointernalError
.I also added a few types back where allowed by JSDoc. In particular, I found that
Map
andSet
generics are allowed.I attempted to create an
IssueError
analog forBidsHedIssue
, but it wouldn't wrap issues created within the partnered schema merge, so I removed it.