Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Adds music adventure level 1 to 14 in English #4991

Merged
merged 28 commits into from
Feb 1, 2024
Merged

Conversation

MarleenGilsing
Copy link
Collaborator

@MarleenGilsing MarleenGilsing commented Jan 11, 2024

Start of #4962

Can be merged once the music notes bugs are resolved.

Depends-On: #5035

@ghost
Copy link

ghost commented Jan 11, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

story_text: |-
Finish the songs! We have started the codes for 3 melodies.
As you can see, you can also use the `{sleep}` command to add a little pause in the song.
example_code: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MarleenGilsing!

I have added a story_text here, because if you have more example codes than story_texts they will not show. I have also removed 1 song, since 3 is a bit much and the block becomes long. Once we have shared adventures (very soon!!) we can add as much as we want :)

{play} notes {at} {random}
{play} notes {at} {random}
```
4:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owww I love this karaoke machine idea!!!!

@Felienne
Copy link
Member

Great work @MarleenGilsing!

I have made changes to the music codes until level 5, these now all work, level 6 not yet, still working on it!!

You can continue adding music adventures tomorrow for the rest of the levels as I am improving the rest of the code,

@Felienne
Copy link
Member

Hi @MarleenGilsing!

Awesome work, just 2 remarks:

Level 9
I think the code might be wrong?
http://localhost:8080/hedy/9#music A second if is missing I think but I did not know how to improve it?

Level 6
It works but it does not really explain why you would use a number. Could we do something like this?

play_number = ask 'Say a starting number'
play play_number
play_number = play_number + 1
play play_number
play_number = play_number + 1
play play_number

or if you want to go this road, we can also do:

play_number = ask 'Say a random number'
play play_number
play play_number + 1
play play_number + 2

That currently does not work but I can make it work :)

@MarleenGilsing
Copy link
Collaborator Author

Hi @Felienne,

The level 9 code didn't work properly indeed, but now it does :)

Your example code for level 6 was better, so I changed it, I also added that it prints the number, so the students might get a better understanding of which sound belongs to which number. One small issue I noticed:
image
After the play command the variable doesn't turn light blue yet. Should I make a seperate issue for this, or is this already in the works.

But this PR is ready to go 👍

@MarleenGilsing MarleenGilsing changed the title 📜 Adds music adventure level 1 to 9 in English 📜 Adds music adventure level 1 to 14 in English Feb 1, 2024
Copy link
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 338af73 into main Feb 1, 2024
11 checks passed
@mergify mergify bot deleted the Music-adventure branch February 1, 2024 16:32
Copy link
Contributor

mergify bot commented Feb 1, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants