-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📜 Adds music adventure level 1 to 14 in English #4991
Conversation
…o Music-adventure
for more information, see https://pre-commit.ci
story_text: |- | ||
Finish the songs! We have started the codes for 3 melodies. | ||
As you can see, you can also use the `{sleep}` command to add a little pause in the song. | ||
example_code: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MarleenGilsing!
I have added a story_text here, because if you have more example codes than story_texts they will not show. I have also removed 1 song, since 3 is a bit much and the block becomes long. Once we have shared adventures (very soon!!) we can add as much as we want :)
{play} notes {at} {random} | ||
{play} notes {at} {random} | ||
``` | ||
4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Owww I love this karaoke machine idea!!!!
for more information, see https://pre-commit.ci
…o Music-adventure
Great work @MarleenGilsing! I have made changes to the music codes until level 5, these now all work, level 6 not yet, still working on it!! You can continue adding music adventures tomorrow for the rest of the levels as I am improving the rest of the code, |
Hi @MarleenGilsing! Awesome work, just 2 remarks: Level 9 Level 6
or if you want to go this road, we can also do:
That currently does not work but I can make it work :) |
for more information, see https://pre-commit.ci
Hi @Felienne, The level 9 code didn't work properly indeed, but now it does :) Your example code for level 6 was better, so I changed it, I also added that it prints the number, so the students might get a better understanding of which sound belongs to which number. One small issue I noticed: But this PR is ready to go 👍 |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Start of #4962
Can be merged once the music notes bugs are resolved.
Depends-On: #5035