Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heimdal: Fix the 32-bit build on FreeBSD #1004

Merged
merged 1 commit into from
Nov 17, 2022
Merged

heimdal: Fix the 32-bit build on FreeBSD #1004

merged 1 commit into from
Nov 17, 2022

Conversation

vlendec
Copy link
Contributor

@vlendec vlendec commented Aug 5, 2022

Format string fixes that fail in the Samba build on a 32-bit machine

Signed-off-by: Volker Lendecke vl@samba.org

Format string fixes that fail in the Samba build on a 32-bit machine

Signed-off-by: Volker Lendecke <vl@samba.org>
@jaltman
Copy link
Member

jaltman commented Sep 23, 2022

We have to be careful with use of %zd because Windows compilers before VS2015 do not support it. Must use %Id instead.

Also, we don't want to cast times to (long). That will only make our existing problems with 32-bit time worse.

samba-team-bot pushed a commit to samba-team/samba that referenced this pull request Nov 2, 2022
REF: heimdal/heimdal#1004
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15220

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
samba-team-bot pushed a commit to samba-team/samba that referenced this pull request Nov 8, 2022
REF: heimdal/heimdal#1004
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15220

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ab4c7bd)

Autobuild-User(v4-16-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-16-test): Tue Nov  8 14:09:47 UTC 2022 on sn-devel-184
samba-team-bot pushed a commit to samba-team/samba that referenced this pull request Nov 8, 2022
REF: heimdal/heimdal#1004
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15220

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit ab4c7bd)
@jaltman jaltman merged commit f4faaea into heimdal:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants