Skip to content

Conversation

colindekker
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d4b9738 on colindekker:master into ** on helior:master**.

@helior
Copy link
Owner

helior commented Oct 20, 2017

Thanks for adding cross-platform compatibility @colindekker! I'll test this on the weekend and hopefully cut a new release before Monday. Cheers!

@helior helior mentioned this pull request Oct 27, 2017
@colindekker
Copy link
Contributor Author

The conflict is in package.json. There seems to be a similar commit with regards to the devdependencies section, i.e. both commits include package upgrades. I suggest keeping the react dependencies dual versioned, i.e. ^15.0.0 || ^16.0.0, the component works with both.

@andreyvital
Copy link

@colindekker @helior any updates?

@helior
Copy link
Owner

helior commented Nov 2, 2017

Thanks for updating your branch @colindekker — Just to share my process, I altered your merge commit to exclude manually bumping the package version. Then after merging your branch back to master I ran npm version patch to auto-bump the package version and add a corresponding git tag. I think because I didn't produce a merge commit that this PR wasn't auto-closed. But at any rate, THANK YOU!

@helior helior closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants