Skip to content

fix: missing authorization #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: missing authorization #208

merged 1 commit into from
Aug 23, 2023

Conversation

pudkrong
Copy link
Contributor

No description provided.

@pudkrong pudkrong requested a review from coderbyheart as a code owner August 23, 2023 14:05
@pudkrong pudkrong merged commit 618ac74 into saga Aug 23, 2023
@pudkrong pudkrong deleted the fix-unauthorized branch August 23, 2023 14:05
coderbyheart
coderbyheart reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@coderbyheart coderbyheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which lambda needs that? Or what doesn't work because of the missing permission?

@pudkrong
Copy link
Contributor Author

It errors when we are trying to publish the message to the web socket that has been closed already as per this line,

backend/websocket/notifyClients.ts

Line 55 in e0db674

eventBus.send(
.

@coderbyheart
Copy link
Member

Since this is obviously not needed, and we don't have a test for it the fix, I would have removed it the message instead.

@coderbyheart coderbyheart mentioned this pull request Aug 24, 2023
Closed
Lenakh97 pushed a commit that referenced this pull request Aug 30, 2023
@pudkrong @Lenakh97
fix: missing authorization (#208)
823e86f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderbyheart coderbyheart coderbyheart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pudkrong @coderbyheart