This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/node-red] node-red chart enhancements #12052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
size/M
k8s-ci-robot
added
the
approved
|
Have you considered using https://kubernetes.io/docs/tutorials/stateful-application/basic-stateful-set/#parallel-pod-management? |
Hi @vsliouniaev, I have not. Is this something we should probably do when using StatefulSets? I would like to make sure that it wouldn't impede with using a block-storage like rook/ceph where you can't have the new pod trying to use the same storage as the old pod (this is a problem when using Deployments with the default RollingUpdate policy) |
|
You will still get the same storage behaviour that you are looking for from StatefulSet - separate volumes will be used per pod |
helm-bot
added
size/M
billimek
force-pushed
the
node-red-statefulset
branch
from
2d79739
to
dbe7ffa
Compare
helm-bot
added
Contribution Allowed
|
Hi @vsliouniaev, I went ahead and included this change too. |
|
/assign @unguiculus |
|
/assign @davidkarlsen |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
3 tasks
* based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com>
Signed-off-by: Jeff Billimek <jeff@billimek.com>
billimek
force-pushed
the
node-red-statefulset
branch
from
dbe7ffa
to
b788297
Compare
Signed-off-by: Jeff Billimek <jeff@billimek.com>
helm-bot
added
size/S
billimek
changed the title
Signed-off-by: Jeff Billimek <jeff@billimek.com>
…o node-red-statefulset * 'node-red-statefulset' of github.com:billimek/charts: Implemented the option to add a subPath when enabling persistence (helm#12517)
|
/retest |
|
/hold cancel |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
crackmac
pushed a commit
to crackmac/charts
that referenced
this pull request
Mar 29, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com>
crackmac
pushed a commit
to crackmac/charts
that referenced
this pull request
Mar 29, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>
devnulled
pushed a commit
to devnulled/charts
that referenced
this pull request
Apr 25, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com>
dermorz
pushed a commit
to dermorz/charts
that referenced
this pull request
Apr 26, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com>
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
* switching node-red chart to SatefulSet * based on the persistent nature of this chart as well as [this discussion](helm#1863), migrating the chart to a StatefulSet instead of a deployment. As a result bumping the major version * bumping node-red docker image to the latest stable version * using volumeClaimTemplates for statefulSet Signed-off-by: Jeff Billimek <jeff@billimek.com> * using Parallel podManagementPolicy Signed-off-by: Jeff Billimek <jeff@billimek.com> * revert to Deployment and leverage strategy types Signed-off-by: Jeff Billimek <jeff@billimek.com> * hard-code replica count Signed-off-by: Jeff Billimek <jeff@billimek.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]