-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP-0011: Informational Helm CRD HIP #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I like this write-up. I think every maintainer and contributor to the space should read it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
architecture/crds.md
Outdated
|
||
The next two subsections explain these. | ||
|
||
### Shared Global Resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove extra space between Global and Resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good detailed discussion on an area which has proved difficult to explain in the Helm community. It will be helpful when trying to find solutions to people's issues. Thanks @technosophos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @technosophos!
As #140 has now been approved and accepted, would you mind following the process described in HIP 1 and rewrite this as an "informational" HIP?
Let me know if you have any questions about the process. I'd be happy to answer them.
Thank you!
This is a challenging situation. Not just in where all the various machinery are at, but where we are as a result as a broader community. That y'all took the time to elaborate all of this accounts to genuine "thought leadership" within this community, in my book. As a member, I'm grateful. 🙏 |
Hi, I have run into issue of helm installing and not updating CRDs and end up here. I have tried to read this explanation deeply and
Sorry to jump directly to PR but as you have closed related bugs there is no other space to ask my question. Thank You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some suggestions on word use, phrasing.
I was granted HIP approval, but no HIP number was granted. So I am claiming HIP-0011. |
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
I have reformatted and fixed up this document. Anything I marked as "resolved" I either changed or decided not to further consider the matter. Given that I can't solve the problem, I believe that this HIP is suitable for merging as an informational document. From there, perhaps we can figure out a better way to have the ongoing dialog about this issue--and have a stable reference that others can use. |
hips/hip-0011.md
Outdated
authors: [ "Matt Butcher <matt.butcher@microsoft.com>" ] | ||
created: "2021-03-26" | ||
type: "informational" | ||
status: "draft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically "informational" HIPs are considered final after approval, as they're meant to serve as information to the general Helm community, and it's not really considered a living document compared to "feature" or "process" HIPs. Do you expect there to be further changes to this document or would you consider this as a final draft?
Do keep in mind that newer HIPs can replace or deprecate older HIPs, so if we change how CRDs are handled later on we can mark this one as superseded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was to document why Helm 3 works the way it does. So it is informational IMO. If a new thing happens for Helm 4, I envision a new HIP for that.
The main thing I was hoping to accomplish is to give people a substantial reference to understand what we have already done and why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bacongobbler @technosophos I think the status can be set to final
. Is that the only change being noted here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bacongobbler are we good to merge at this point? You still have a nay vote on this PR.
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
This is a draft of a document to provide a complete explanation of the CRD conundrum in Helm. The intention is to have one formal statement that we can direct others to so that they understand:
Signed-off-by: Matt Butcher matt.butcher@microsoft.com