-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce HIP 1: "Writing a HIP" #140
Conversation
590a12c
to
1911ce8
Compare
HEP, like a hepcat (https://en.wikipedia.org/wiki/Hipster_(1940s_subculture))? HIP, Helm Improvement Proposal? |
As discussed in today's call, I'll bring this to the helm-cartographers mailing list so other project maintainers can weigh in and see if this process would be helpful for them as well. |
side note: I like HIP simply for the fact that it relates to a familiar english word, whereas HEP is common slang for a well-known subset of viruses (hepatitis C is commonly shortened down to "HEP C"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. Just some general feedback and edits
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
1911ce8
to
e7ddce4
Compare
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Okay, I think I've addressed all outstanding comments. I also included HIP 2 which provides a sample HIP template for others to use when writing their own HIPs. Ready for another round of reviews! |
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
cfb1e39
to
d835714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bacongobbler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I am just a user of Helm)
I went through this and I like it very much. I left minor comments.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As the Helm project receives more and more proposals, we should try to set a reasonable standard which proposal authors should adhere to ensure that proposals to the Helm project are well-written, thought out, and explained in a clear, concise manner.
This proposal format is inspired heavily by the Python Enhancement Proposal (PEP) process, with some minor modifications called out in proposal 1 (Writing a Proposal). I did not provide this process a fun name (KEPs, PEPs, DEPs), but suggestions are welcome, as it would make it simpler to reference these proposals in conversation!