Skip to content

docs: credit ArthurKa for helmet#303 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: credit ArthurKa for helmet#303 #50

wants to merge 1 commit into from

Conversation

ArthurKa
Copy link

No description provided.

@ArthurKa ArthurKa changed the title docs: credit ArthurKa for helmet#303 docs: credit ArthurKa for [helmet#303](https://github.com/helmetjs/helmet/pull/303) Apr 22, 2021
@ArthurKa ArthurKa changed the title docs: credit ArthurKa for [helmet#303](https://github.com/helmetjs/helmet/pull/303) docs: credit ArthurKa for helmet#303 Apr 22, 2021
EvanHahn
EvanHahn requested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move your name so it's in alphabetical order? You'd be at the end of the A's.

If not, I can do it.

@ArthurKa
Copy link
Author

Sure :)

@ArthurKa
Copy link
Author

But is it possible to do if I already delete fork?

@EvanHahn
Copy link
Member

Hmm, maybe not. I'll take care of it.

@ArthurKa
Copy link
Author

Thanks! By the way it look like I forgot to add new line at the end of file :(

@EvanHahn
Copy link
Member

Did this myself in 3dae7df. Thanks again for your contribution!

@EvanHahn EvanHahn closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurKa @EvanHahn