The app crashes randomly after update to 3.7.7 version on windows 10

[headzzzz]

Checklist

• I have used the search function to see if someone else has already submitted the same bug report.
• I will describe the problem with as much detail as possible.

App version

3.7.7

Windows version

Windows 10 22H2 (build 19045.3803)

Steps to reproduce

Randomly crashing application
simplewall-1704305452.dmp

Means: "The instruction at address 0x%p referenced memory address 0x%p. Unable to perform memory operation: %s. (0xC0000005)"

Expected behavior

After crash, application is ended

Actual behavior

Crashed

Logs

No response

[privacyguy123]

Same

simplewall-1704306556.dmp

[henrypp]

now it fixed, sorry, download here

[henrypp]

@privacyguy123 i cant understand where it crashed if u dont get crash dump

[henrypp]

@Alcazer it cant help, ONLY DUMP, SHIT

[henrypp]

@hushkamala u not using fix.

[henrypp]

@hushkamala

orly? in ur dumps ptr_app was nullptr it CANT be happened, because it was checked for NPE in 97 line in fix. so, there is problem not in me

[henrypp]

@hushkamala i can only re-upload fix:
simplewall.zip

there is nothing changed in SW except project sdk

[hushkamala]

@henrypp I'm sorry but the first fix posted was really the same as 3.7.7 version. Or something is very wrong on my side. Downloaded it 3 times and checked not only crc32 hash. I apologize if the problem is my doing.

On this last fix it is not crashing for me. Thank you and sorry if the mistake is mine.

[Alcazer]

@hushkamala i can only re-upload fix: simplewall.zip

there is nothing changed in SW except project sdk

@henrypp I'm sorry but the first fix posted was really the same as 3.7.7 version. Or something is very wrong on my side. Downloaded it 3 times and checked not only crc32 hash. I apologize if the problem is my doing.

On this last fix it is not crashing for me. Thank you and sorry if the mistake is mine.

+1, i also checked it and not crashing

[nullptr-deref]

@henrypp since you are the owner and the leading maintainer of this very repository, I believe that it's most certainly your concern of delivering hot fixes & patches somehow properly, or at least provide somewhat like a quickfix instruction about what toolset one should use when posting fixes in such a manner.
There's loads of archivers on the market, and nobody (not even you) previously mentioned 7zip is a "must-have" in the discussion in question.

Nevertheless, I appreciate your effort you've put into developing simplewall.

Will inform if the issue is resolved for me.

[nullptr-deref]

After half an hour long observation seems like crash is now completely gone.

For the sake of complete clarity about unarchiving and installing the patch I'll mention once more that one shouldn't use default Windows zip utility but something like WinRAR or 7zip instead because Windows archiver can possibly treat archive as corrupt.

[henrypp]

@nullptr-deref it bcs github did not allow 7z or rar files (did not understand) to attach but this is 7z archive renamed to zip

and w11 23h2 has added support to open & create support for anything u want, 7z rar etc normally supported

[Cthululz]

@hushkamala i can only re-upload fix: simplewall.zip

there is nothing changed in SW except project sdk

sorry for dogpiling on just wanted to let you know that I'm running this now and it's not crashing anymore when i go to the connection tab

thank you

[xp80]

@hushkamala i can only re-upload fix: simplewall.zip
there is nothing changed in SW except project sdk

@henrypp I'm sorry but the first fix posted was really the same as 3.7.7 version. Or something is very wrong on my side. Downloaded it 3 times and checked not only crc32 hash. I apologize if the problem is my doing.
On this last fix it is not crashing for me. Thank you and sorry if the mistake is mine.

+1, i also checked it and not crashing

this fix worked for me

[privacyguy123]

Can't reproduce with "sha-256" option turned off

[Rubber-Duckie]

Sounds like you fixed it, well done. Do you have an estimation on an official release?

[henrypp]

@Rubber-Duckie no

[TheArkive]

The Fix worked for me. Thanks. I love this program.

[crash5]

Will there be a release from this fix?

[henrypp]

@crash5 soon, i hope

[Rubber-Duckie]

We all need to follow some basic best practices which will avoid these situations.
Firstly, this could have been compensated for had there been unit text code coverage during unit testing. Mock out possible 3rd party libraries. If you have any code that interacts with third-party libraries, you must validate and check all the parameters in and out. Most 4GL languages do basic type checking, but you need to use strong typing for any custom structs or else parse them explicitly. This can prevent many exploits and exception cases. And don't forget, third-party libraries are not reliable, so you need to have good exception management around any call to them. If your application crashes because of poor exception handling, that's on you, not the third-party library. All you need here is a graceful way of handling exceptions from third-party dependent API calls. For example, the grid should omit data that was expected from the API call, not crash completely like a drama queen. Also, a sensible message to the user to suggest they look at the exception log since something went wrong while doing XYZ. Use an exception logging framework. I have to say, you do act like a bit of a diva :D with your use of language. I guess your code reflects that. https://gkovan.medium.com/build-to-manage-proper-exception-handling-makes-your-applications-easier-to-build-and-manage-9105dbaf2862