Skip to content

Fix Circular import issue in NodeList #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2021
Merged

Fix Circular import issue in NodeList #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0094e4b
Create NodeList.py
hepheir Jun 2, 2021
f4ee67c
Implement `NodeList` based on `list` type
hepheir Jun 2, 2021
48ab505
Create unittest for `NodeList`
hepheir Jun 2, 2021
56ab2a8
Unimport unused interface `DOMException`
hepheir Jun 2, 2021
fc1811b
Fix circular import issue
hepheir Jun 2, 2021
cac36dc
Merge branch 'Hepheir/w3.python.core.fundamental_interface.Node' into…
hepheir Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions w3/python/core/fundamental_interface/NodeList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
from typing import Optional
from typing import Any, Optional

from w3.python.core.fundamental_interface.Node import Node


_AnyNode = Node
_AnyNode = Any

class NodeList(list):
"""Interface NodeList
Expand Down
1 change: 0 additions & 1 deletion w3/python/core/fundamental_interface/NodeList_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Iterator
import unittest

from w3.python.core.fundamental_interface.DOMException import DOMException
from w3.python.core.fundamental_interface.Node import Node
from w3.python.core.fundamental_interface.Node import NodeType
from w3.python.core.fundamental_interface.NodeList import NodeList
Expand Down