Skip to content

Conversation

hepheir
Copy link
Owner

@hepheir hepheir commented May 27, 2021

No description provided.

@hepheir hepheir self-assigned this May 27, 2021
@hepheir hepheir merged commit f87d4d2 into Hepheir/issue2 May 27, 2021
@hepheir hepheir deleted the Hepheir/python.dom.NodeList branch May 27, 2021 14:56
hepheir added a commit that referenced this pull request May 27, 2021
As of the implementation of `NodeList` (#6), `NodeList` supports the methods of list.
Therefore, replaced the T/F evaluating expression.

before: `if self.child_nodes.length == 0:`
after: `if not self.child_nodes:`

to read more about "Google Python Style Guide":
https://google.github.io/styleguide/pyguide.html#s2.14-truefalse-evaluations
@hepheir hepheir changed the title Implement interface NodeList [Removed PR] Implement interface NodeList May 31, 2021
@hepheir hepheir added the wontfix This will not be worked on label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant