Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-sqlite3 does not currently support RETURNING clause #58

Closed
jhomarolo opened this issue Jul 12, 2022 · 1 comment · Fixed by #59
Closed

node-sqlite3 does not currently support RETURNING clause #58

jhomarolo opened this issue Jul 12, 2022 · 1 comment · Fixed by #59
Labels
bug Something isn't working released Already in production

Comments

@jhomarolo
Copy link
Contributor

jhomarolo commented Jul 12, 2022 •
edited
Loading

Describe the bug
The method insert used inside herbs2knex has the returning clause wich is not supported by sqllite3. So calling the insert method the inserted id not returns

Expected behavior
The id of the inserted objects should return

I'm using this config:

 client: 'sqlite3',
    connection: { filename: "file:memDb1?mode=memory&cache=shared" },
    useNullAsDefault: true,
    migrations: {
      directory: './src/infra/db/migrations',
      tableName: 'knex_migrations'
    }
@jhomarolo jhomarolo added the bug Something isn't working label Jul 12, 2022
jhomarolo added a commit to jhomarolo/herbs2knex that referenced this issue Jul 17, 2022
@jhomarolo
fix(sqlite): fix returning sqlite and add tests for support sqlite
74240b4 
fix herbsjs#58
@jhomarolo jhomarolo mentioned this issue Jul 17, 2022
Merged
4 tasks
github-actions bot pushed a commit that referenced this issue Jul 18, 2022
@semantic-release-bot
chore(release): 1.5.3 [skip ci]
3176477 
## [1.5.3](v1.5.2...v1.5.3) (2022-07-18)

### Bug Fixes

* **herbs:** change gotu and suma to peerDependencies ([9caa5e4](9caa5e4))
* **sqlite:** fix returning sqlite and add tests for support sqlite ([74240b4](74240b4)), closes [#58](#58)
@herbsjs-robot
Copy link

🎉 This issue has been resolved in version 1.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@herbsjs-robot herbsjs-robot added the released Already in production label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released Already in production
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sqlite): fix returning sqlite and add tests for support sqlite jhomarolo/herbs2knex
2 participants
@jhomarolo @herbsjs-robot