Separate thousands with an underscore when generating Rust #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Feron <feron.gabriel@gmail.com>
gferon
force-pushed
the
thousands-separator
branch
from
a1b4f07
to
d959e15
Compare
boxdot
requested changes
Jan 13, 2019
Signed-off-by: Gabriel Feron <feron.gabriel@gmail.com>
gferon
force-pushed
the
thousands-separator
branch
from
f4babed
to
7ca8a69
Compare
boxdot
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what's best: try to parse the string value to an integer and fail gracefully, or test if the
node.type.nameis in an integer (sou8,u16, etc.). I chose here to parse the value, which is more future proof IMHO.Resolves #84