Porting Rust implementation to C++ #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeaaC
force-pushed
the
veaac/cpp_revamp
branch
2 times, most recently
from
a8f1cf4
to
e9c41e2
Compare
lene
reviewed
Feb 16, 2021
VeaaC
force-pushed
the
veaac/cpp_revamp
branch
2 times, most recently
from
f6a8288
to
bab785f
Compare
VeaaC
changed the title
|
@lene should be ready for review now. Produces same results as Rust impl, and checks out against the global test-data. |
Closed
lene
reviewed
Feb 23, 2021
There was a problem hiding this comment.
Overall I'd say I don't like the Polyline = std::variant<Polyline2d, Polyline3d> definition and the "switch on type" semantics that it brings, and I am not sure this is a good way to go for a reference implementation.
That said, this is a significant improvement over the old implementation already and I leave it to you whether you want to invest the work to change the implementation. Or maybe you have other reasons to keep it this way.
lene
approved these changes
Feb 24, 2021
Signed-off-by: Christian Vetter <christian.vetter@here.com>
VeaaC
force-pushed
the
veaac/cpp_revamp
branch
from
4572dc9
to
53050c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #37
Still missing: CLI app + shared testing framework