This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-12677: Extract PoiRenderer from TextCanvas #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraukeF
force-pushed
the
poi-renderer
branch
from
8ca17aa
to
8e51d94
Compare
|
@harpgl-bot retest this please |
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
- Coverage 66.16% 66.14% -0.03%
==========================================
Files 295 294 -1
Lines 26294 26299 +5
Branches 5909 5909
==========================================
- Hits 17398 17395 -3
- Misses 8896 8904 +8
Continue to review full report at Codecov.
|
atomicsulfate
suggested changes
Nov 30, 2020
FraukeF
force-pushed
the
poi-renderer
branch
from
1e73179
to
3e21fea
Compare
|
@harpgl-bot retest this please |
|
@harpgl-bot retest this please |
atomicsulfate
suggested changes
Dec 2, 2020
|
macbook tests please |
1 similar comment
|
macbook tests please |
atomicsulfate
previously approved these changes
Dec 3, 2020
added 13 commits
December 3, 2020 11:28
* Makes PoiRenderer independent from TextCanvas * PoiRenderer renders on its own * Icons can be rendered even if no FontCatalog is availble Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
* PoiRenderer supports callback between layers * TextCanvas supports rendering of layers inside a scope Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
…d TextCanvas Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
…ache Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
* PoiRenderer passes PoiLayer to PoiBuffer instead of the whole instance * Removes MapView Dependency, and passes only needed information instead Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Change-Id: I16eea8ce448f8f172351afd4f1fbd3efb3162b9b Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
…furter cleanup in PoiRenderer * PoiRenderer only creates new layer on actual Buffer generation * PoiInfos with already created buffers from a former PoiRenderer are handled * MapView contains one PoiRenderer which is reset instead of recreated on theme change * Fixes issue introduced to TextStyleCache not being able to access config name of FontCatalog Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
…furter cleanup in PoiRenderer * PoiRenderer only creates new layer on actual Buffer generation * PoiInfos with already created buffers from a former PoiRenderer are handled * MapView contains one PoiRenderer which is reset instead of recreated on theme change * Fixes issue introduced to TextStyleCache not being able to access config name of FontCatalog Change-Id: Ie4b961b37904d10940d76ec2ae62e3eb282bcb58 Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
|
macbook tests please |
|
@harpgl-bot retest this please |
|
macbook tests please |
atomicsulfate
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frauke Fritz frauke.fritz@here.com
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!