Update-able TextStyleCache

[FraukeF]

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

• contribution guidelines
• coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

[codecov]

Codecov Report

Merging #2017 (f421ef5) into master (2c4ebb6) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
+ Coverage   66.41%   66.56%   +0.14%     
==========================================
  Files         297      297              
  Lines       26337    26338       +1     
  Branches     5939     5941       +2     
==========================================
+ Hits        17493    17531      +38     
+ Misses       8844     8807      -37     

Impacted Files	Coverage Δ
...here/harp-mapview/lib/text/TextElementsRenderer.ts	71.94% <100.00%> (-0.04%)	⬇️
@here/harp-mapview/lib/text/TextStyleCache.ts	68.83% <100.00%> (+15.55%)	⬆️
@here/harp-utils/lib/Logger/ConsoleChannel.ts	38.46% <0.00%> (+15.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4ebb6...f421ef5. Read the comment docs.

[FraukeF]

@harpgl-bot retest this please

[atomicsulfate]

Just a minor comment.

[atomicsulfate]

Suggested change

	textStyleDefinitions?.forEach(element => {
	this.m_textStyles.set(
	element.name!,
	this.createTextElementStyle(element, element.name!)
	);
	});
	// Remove obsolete
	for (const [name] of this.m_textStyles) {
	if (
	textStyleDefinitions.findIndex(definition => {
	return definition.name === name;
	}) === -1
	) {
	this.m_textStyles.delete(name);
	}
	}
	this.m_textStyles.clear();
	textStyleDefinitions.forEach(element => {
	this.m_textStyles.set(
	element.name!,
	this.createTextElementStyle(element, element.name!)
	);
	});

[atomicsulfate]

• textStyleDefinitions is always defined in the else branch of the condition statement.
• Why not just clearing the text styles map before adding the new ones. Since we're overwriting with the new text styles, it should be the same.

[FraukeF]

done

[FraukeF]

retest this please

[FraukeF]

retest this please