Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-14502: Fixes blue-ish webtiles on sphere #2133

Merged
merged 3 commits into from
Mar 4, 2021
Merged

HARP-14502: Fixes blue-ish webtiles on sphere #2133

merged 3 commits into from
Mar 4, 2021

Conversation

FraukeF
Copy link
Contributor

@FraukeF FraukeF commented Mar 4, 2021

Signed-off-by: Frauke Fritz frauke.fritz@here.com

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
nzjony
nzjony previously approved these changes Mar 4, 2021
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
nzjony
nzjony previously approved these changes Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2133 (b310598) into master (3edcac6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   67.70%   67.70%   -0.01%     
==========================================
  Files         298      298              
  Lines       26374    26377       +3     
  Branches     5969     5970       +1     
==========================================
+ Hits        17856    17858       +2     
- Misses       8518     8519       +1     
Impacted Files Coverage Δ
...e/harp-mapview/lib/geometry/TileGeometryCreator.ts 71.75% <ø> (ø)
@here/harp-mapview/lib/poi/PoiManager.ts 12.85% <ø> (ø)
@here/harp-mapview/lib/text/TextElementBuilder.ts 98.94% <ø> (ø)
...here/harp-mapview/lib/text/TextElementsRenderer.ts 72.11% <ø> (ø)
@here/harp-webtile-datasource/lib/WebTileLoader.ts 100.00% <ø> (ø)
@here/harp-mapview/lib/PickHandler.ts 82.43% <100.00%> (+0.11%) ⬆️
@here/harp-mapview/lib/text/TextElement.ts 93.67% <100.00%> (+0.08%) ⬆️
@here/harp-mapview/lib/geometry/AddGroundPlane.ts 98.82% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edcac6...3d2af9f. Read the comment docs.

Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
@FraukeF FraukeF closed this Mar 4, 2021
@FraukeF FraukeF reopened this Mar 4, 2021
@FraukeF FraukeF closed this Mar 4, 2021
@FraukeF FraukeF reopened this Mar 4, 2021
@FraukeF FraukeF closed this Mar 4, 2021
@FraukeF FraukeF reopened this Mar 4, 2021
@FraukeF FraukeF merged commit fe19681 into master Mar 4, 2021
@FraukeF FraukeF deleted the HARP-14502 branch March 4, 2021 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants