Java base64 #35
Merged
Java base64 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 3, 2018 00:08
This removes the dependency to commons-codec and any references on the code to org.apache.commons.codec.binary.Base64. This is done in favor of Java's java.util.Base64 class.:
|
Checkout https://github.com/heremaps/here-aaa-java-sdk/tree/ken-java-base64 if you want to see a test proving the old implementation and new implementation return the same data. I'm intentionally keeping that branch separate from the pull request branch, so we can completely remove commons-codec dependency. But the proof we can use the alternate implementation, and that in doing so it improves performance, is in ken-java-base64 branch. |
|
Hi @srrajago, let me know if I can be of any help. |
srrajago
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base64: switch from commons-codec Base64 implementation, to java.util.Base64.
Remove dependency on commons-codec Base64.