Auto dismiss location warning popup #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/landing_screen.dart
Outdated
| @@ -423,6 +428,10 @@ class _LandingScreenState extends State<LandingScreen> with Positioning { | |||
| ); | |||
|
|
|||
| Overlay.of(context)!.insert(_locationWarningOverlay!); | |||
| Timer.periodic(Duration(seconds: _kLocationWarningDismissPeriod), (timer) { | |||
There was a problem hiding this comment.
It seems that you want this to fire only once. In that case don't use Timer.periodic + cancel. Just use Timer(Duration(..)). It will fire once and you don't have to cancel it.
Signed-off-by: Vitalii Khoruzhyi <44439675+Merlin1stHere@users.noreply.github.com>
Merlin1stHere
force-pushed
the
auto_dismiss_location_warning
branch
from
5374cda
to
f1c7083
Compare
ppiatkowski-here
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Khoruzhyi 44439675+Merlin1stHere@users.noreply.github.com