Allow initialization of the location engine even location services are disabled #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merlin1stHere
force-pushed
the
fix_positioning_if_reenabled
branch
from
4c30b0d
to
53e73dc
Compare
tstaszak89
reviewed
Sep 10, 2021
lib/positioning/positioning.dart
Outdated
| @@ -194,5 +192,14 @@ mixin Positioning { | |||
|
|
|||
| void _onStatusChanged(LocationEngineStatus status) { | |||
| _onLocationEngineStatus?.call(status); | |||
There was a problem hiding this comment.
I think that you should not call _onLocationEngineStatus?.call(status); if positioning is disabled.
…e disabled Signed-off-by: Vitalii Khoruzhyi <44439675+Merlin1stHere@users.noreply.github.com>
Merlin1stHere
force-pushed
the
fix_positioning_if_reenabled
branch
from
53e73dc
to
6f22226
Compare
tstaszak89
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow application to receive location updates when location services are enabled again.