Exclude tests submodules from package #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sackh
suggested changes
Aug 18, 2021
|
I think that was on purpose for xyzspaces when I wrote it at the beginning, so people could also run the tests easily without the need to clone the whole repo. At least I think that was the reason. But if that's an issue with including it in the QGis-Plugin feel free to remove them... |
|
@deeplook , it is not really an issues with the QGIS plugin, but I find it strange when there is a tests package after pip install. If we want to include tests with the published package we could include it as submodule xyzspaces.tests imo. |
Signed-off-by: minff <16268924+minff@users.noreply.github.com>
sackh
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current setup.py, pip install would still install "tests" package at the same level as xyzspaces package. Added wildcard pattern to exclude it