Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Space clone functionality #93

Merged
merged 15 commits into from
Oct 15, 2020
Merged

Added Space clone functionality #93

merged 15 commits into from
Oct 15, 2020

Conversation

omanges
Copy link
Contributor

@omanges omanges commented Oct 15, 2020

Signed-off-by: Omkar Mestry omkar.mestry@here.com

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@omanges omanges requested a review from sackh October 15, 2020 06:32
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
xyzspaces/spaces.py Outdated Show resolved Hide resolved
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
…python into clone_space

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
…python into clone_space

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
Copy link
Contributor

@deeplook deeplook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will comment later.

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #93 into master will decrease coverage by 0.39%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   97.97%   97.57%   -0.40%     
==========================================
  Files          10       10              
  Lines         888      907      +19     
==========================================
+ Hits          870      885      +15     
- Misses         18       22       +4     
Impacted Files Coverage Δ
xyzspaces/spaces.py 96.03% <78.94%> (-1.06%) ⬇️

xyzspaces/spaces.py Outdated Show resolved Hide resolved
xyzspaces/spaces.py Outdated Show resolved Hide resolved
xyzspaces/spaces.py Outdated Show resolved Hide resolved
xyzspaces/spaces.py Outdated Show resolved Hide resolved
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@omanges omanges requested a review from deeplook October 15, 2020 08:10
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
Copy link
Contributor Author

@omanges omanges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
…python into clone_space

# Conflicts:
#	tests/space/test_space_objects.py
xyzspaces/spaces.py Outdated Show resolved Hide resolved
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
xyzspaces/spaces.py Outdated Show resolved Hide resolved
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@omanges omanges merged commit 88f6beb into master Oct 15, 2020
@sackh sackh deleted the clone_space branch October 20, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants