Skip to content

Commit

Permalink
add timeout fix from nakama- 75327bcdb56bc871fed11a57d94e39c73412b71
Browse files Browse the repository at this point in the history
  • Loading branch information
Luke Gehorsam committed Jan 30, 2021
1 parent 0ab6b8e commit 4d4240c
Showing 1 changed file with 0 additions and 0 deletions.
Binary file modified Packages/Nakama/Runtime/Plugins/Nakama.dll
Binary file not shown.

2 comments on commit 4d4240c

@ernesernesto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lugehorsam

Hi, I just noticed that HttpRequestAdapter don't use timeout value when sending a request, is this a fix for that?

also more questions, what is the advantage between using HttpRequestAdapter vs using UnityWebRequestAdapter?
creating default client with new Client(...) would always create a gzip HttpRequestAdapter, and on release build some calls would hang with a long timeout before a response is retrieved.

Since changing the adapter means changing the base call mechanism, we're trying expect some things failing or not working correctly and need to take note of when changing it to UnityWebRequestAdapter, so if you know some info that would break and for us that need to change it would be great

Thanks for clarifying!

@lugehorsam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ernesernesto if you're not having problems with your current adapter I wouldn't necessarily worry about switching, but UnityWebRequestAdapter has better cross-platform support.

The .NET adapter needs access to network sockets on its platform and this isn't possible in a browser context, so only UnityWebRequestAdapter will work there.

As for the timeout fix - yes this is the fix for that and I'd bring in the fix by adding v2.7.1 to your Unity package manifest.

Please sign in to comment.