Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] heroku pipeline:config:edit #1489

Open
mathieutu opened this issue Apr 27, 2020 · 3 comments
Open

[FEATURE] heroku pipeline:config:edit #1489

mathieutu opened this issue Apr 27, 2020 · 3 comments

Comments

@mathieutu
Copy link

Hi, with the new version of heroku review apps, the ENV vars are set in their own interface and not anymore in the app they inherit.

I'm maybe wrong, but there is no way to configure theses env vars in cli for now.

If think the exact config behavior could be added in the pipeline topic.

Thanks.

@robotfelix
Copy link

+1 for this.

Beyond the CLI, at the very least starting with the (old) parent app's config would be a much better experience.

However as it stands, after upgrading I was immediately left needing to enter 60+ environment variables and very surprised to find there is no way to set them via the CLI.

FWIW I tend to use heroku config:set rather than heroku config:edit, so equivalently heroku pipelines:config:set would be the command I'm after!

@robotfelix
Copy link

After investigating this a bit further, it seems like the relevant endpoint does exist in the Platform API, so it's just the CLI where it is omitted / not yet implemented.

In the meantime, for anyone wanting to update multiple config variables at once and/or update config variable from the command line, you can do it with a command like the below (note that the stage is "review" and the pipeline must be referenced by ID and not name):

$ curl -n -X PATCH https://api.heroku.com/pipelines/$PIPELINE_ID/stage/review/config-vars \
  -d '{
  "FOO": "bar",
  "BAZ": "qux"
}' \
  -H "Content-Type: application/json" \
  -H "Accept: application/vnd.heroku+json; version=3"

Source: https://devcenter.heroku.com/articles/platform-api-reference#pipeline-config-vars-update

@jstvz
Copy link

jstvz commented May 19, 2022

Would an external PR implementing this feature be reviewed/accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants