fix(cli): use uuid rather than addon name for pg:credentials #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
force-pushed
the
mi/credentials-uuid
branch
from
2f9359a to
4ce719a
Compare
eablack
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://heroku.support/1140923
We are currently using the addon name to query the API for postgres credentials. This breaks after addons are renamed using
addons:rename. This PR updates the command to use a uuid, a method we largely switched to in 2017. A few commands have yet to be updated, including this one.We are waiting on Data to implement support for UUID, until then this PR can not be tested -> https://salesforce-internal.slack.com/archives/C02LKCXMAEM/p1661381725900759