Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg:upgrade): support essential dbs #2637

Merged
merged 10 commits into from
Mar 1, 2024
Merged

Conversation

binarycleric
Copy link
Contributor

@binarycleric binarycleric commented Feb 14, 2024

This code is still a work-in-progress but I am just trying to get an idea of what changes would be required in the CLI for us to support pg:upgrade on the essential tier.

Testing

These command tests check the warning output of the command based on the type of db's included in the upgrade. Once you've seen the message, Cntrl + C to cancel the upgrade.

This tests a follower db

  • ./bin/run pg:upgrade HEROKU_POSTGRESQL_BRONZE -a heroku-cli-test-staging -v 14
  • Check that the warning message includes the followed db --> (HEROKU_POSTGRESQL_CRIMSON)
  • Cntrl + C to cancel the upgrade.

This tests a non-follower db

  • ./bin/run pg:upgrade HEROKU_POSTGRESQL_TEAL -a heroku-cli-test-staging -v 14
  • Check that the warning message does not include any followed dbs like so...
postgresql-objective-63454 will be upgraded to a newer PostgreSQL version.

  This cannot be undone.
  • Cntrl + C to cancel the upgrade.

binarycleric and others added 2 commits February 14, 2024 14:30
This code is still a work-in-progress but I am just trying to get an
idea of what changes would be required in the CLI for us to support
pg:upgrade on the essential tier.
Waiting for feedback before finalizaing updated tests
@zwhitfield3 zwhitfield3 marked this pull request as ready for review February 28, 2024 23:04
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner February 28, 2024 23:04
@zwhitfield3 zwhitfield3 changed the title Proof-of-concept on changes to support essential pg:upgrade feat(pg:upgrade): support essential dbs Feb 28, 2024
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of questions on this one.

Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and looks good. Thank you!

@zwhitfield3 zwhitfield3 merged commit c062c59 into main Mar 1, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the spike-cli-aurora-pg-upgrade branch March 1, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants