-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pg:upgrade): support essential dbs #2637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is still a work-in-progress but I am just trying to get an idea of what changes would be required in the CLI for us to support pg:upgrade on the essential tier.
Waiting for feedback before finalizaing updated tests
de236df
to
e7a0bb0
Compare
k80bowman
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple of questions on this one.
7ebccd4
to
4d7a684
Compare
k80bowman
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works and looks good. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is still a work-in-progress but I am just trying to get an idea of what changes would be required in the CLI for us to support pg:upgrade on the essential tier.
Testing
These command tests check the warning output of the command based on the type of db's included in the upgrade. Once you've seen the message,
Cntrl + C
to cancel the upgrade.This tests a follower db
./bin/run pg:upgrade HEROKU_POSTGRESQL_BRONZE -a heroku-cli-test-staging -v 14
HEROKU_POSTGRESQL_CRIMSON
)Cntrl + C
to cancel the upgrade.This tests a non-follower db
./bin/run pg:upgrade HEROKU_POSTGRESQL_TEAL -a heroku-cli-test-staging -v 14
Cntrl + C
to cancel the upgrade.