Fix critical security alert for flat package <= 5.0.0
#2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k80bowman
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we're fixing this Critical security alert from Dependabot.
There was a transitive dependency on
flat: ^4.1.0introduced byyargs-unparser: 1.6.0, which in turn, was a dependency for Mocha in versions 6.x and 7.x.The solution to remove the dependency on the risky version of
flatwas to update Mocha to 8.4.0.Mocha 8.x introduced breaking changes for the test configurations, removing the ability to read configuration from
mocha.optsfiles (deprecated in 7.x), in favor of amochaproperty onpackage.jsonfiles. Here we make that conversion to fix the test suite.SOC2 Compliance
GUS Work Item