Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): update fig autocomplete workflow #2679

Merged
merged 12 commits into from Mar 4, 2024

Conversation

zwhitfield3
Copy link
Contributor

Description

Work Item
Work Item

This PR updates the workflow for the Fig Autocomplete to get the latest config of the Heroku CLI in the form of a PR to Fig Autocomplete's repo when a new version of the Heroku CLI is released.

@zwhitfield3
Copy link
Contributor Author

Some context for the updated acceptance test commit.

Due to the way Github workflows prevent yarn.locks from updating during execution, implementing the the fig spec required us to update our plugins property in the /packages/cli's package.json file. This now shows in our acceptance test which is why this commit exists.

@zwhitfield3 zwhitfield3 marked this pull request as ready for review March 4, 2024 22:20
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner March 4, 2024 22:20
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwhitfield3 zwhitfield3 merged commit 536b2ec into main Mar 4, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/fig-integration-v2 branch March 4, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants