Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(local): Ignore env specification when it's not a file #2698

Merged
merged 4 commits into from
Mar 15, 2024
Merged

bug(local): Ignore env specification when it's not a file #2698

merged 4 commits into from
Mar 15, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Mar 8, 2024 •
edited
Loading

#2007

Description

heroku local and heroku run allow users to specify an env file location. If that location is a directory instead, the command fails. This adds logic to ignore env file locations that are not files, and warns the user.

Testing

  1. Pull down branch and run local web within an app's directory that has a .env that is a directory
  2. See that .env is ignored and warns the user

@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:08 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:08 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:08 — with GitHub Actions Inactive
@eablack eablack changed the title bug(local): Provide understandable error when env file is not a file bug(local): Ignore env specification when it's not a file Mar 8, 2024
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:40 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:40 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 22:40 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 23:34 — with GitHub Actions Inactive
@eablack eablack force-pushed the eb/prevent-non-file-envs branch from 8400161 to 7e77c20 Compare March 8, 2024 23:35
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 23:35 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 23:35 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 8, 2024 23:35 — with GitHub Actions Inactive
@eablack eablack marked this pull request as ready for review March 8, 2024 23:35
@eablack eablack requested a review from a team as a code owner March 8, 2024 23:35
justinwilaby
justinwilaby requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~ A small logical error prevented me from getting the warning during testing. ~~
After clarification, it is intentional that the warning will not be displayed under certain circumstances.

justinwilaby
justinwilaby approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eablack eablack force-pushed the eb/prevent-non-file-envs branch from 7e77c20 to caa5dc9 Compare March 15, 2024 00:35
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 00:35 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 00:35 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 00:35 — with GitHub Actions Inactive
@eablack eablack requested a review from justinwilaby March 15, 2024 16:27
justinwilaby
justinwilaby approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eablack eablack force-pushed the eb/prevent-non-file-envs branch from caa5dc9 to c9912b7 Compare March 15, 2024 16:33
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 16:33 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 16:34 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests March 15, 2024 16:34 — with GitHub Actions Inactive
@eablack eablack merged commit d23407c into main Mar 15, 2024
8 checks passed
@eablack eablack deleted the eb/prevent-non-file-envs branch March 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eablack @justinwilaby