fix(workflow): update test-installed-cli #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwhitfield3
force-pushed
the
zw/prerelease-workflow-update
branch
from
c217e2a
to
c99727d
Compare
zwhitfield3
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
zwhitfield3
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
zwhitfield3
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like our
test-installed-clifails when trying to update viaheroku update --version=<some version>. This PR address that issue by runningheroku update betaand then checking that the correct version was upgraded in a comparison statement with our expected version output. It is unclear why the previous version doesn't work, short of the github workflow trying to pick up changes that haven't finished processing.