Refactor!: migrate all legacy commands to Typescript and oclif/core and move them to the cli package #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Type the addon for filtering. * Update to explicitly type addonsToWaitFor * Use temporary type instead of ignoring type error.
* refactor(W-14142188): addons-v5: Upgrade addons:upgrade * Added addons:downgrade alias * Removed addons-v5 since no more commands exist there
* Refactor stub for clarity * Move 'container:logout' to CLI, OClif & TS * Adding missed unit tests for migrated DockerHelper lib functions * Fix usage of any when catching error Co-authored-by: Justin Wilaby <jwilaby@gmail.com> --------- Co-authored-by: Justin Wilaby <jwilaby@gmail.com>
…package (#2654) * refactor: initial refactor for releases:info command * refactor: add logic for getting user email * refactor: fix shell-escape import * refactor: complete initial command migration * refactor: cleanup command * refactor: migrate tests for releases:info * refactor: remove v5 releases:info command and test files * refactor: remove the apps-v5 package and plugin imports * chore: update yarn.lock * refactor: add --remote flag to all releases commands * fix: move call for config and update userEmail variable and update test * fix: remove apps-v5 again after rebase
…o oclif (#2656) * Convert container:rm to oclif * Convert rm test to test oclif version * Remove rm from container-v5 * Update test output check * Include docker variant header and expect it in test
…to oclif (#2657) * Convert container:run to oclif * Convert container run test to oclif * Fix test expectation * Update text output expectation * Change runImage function interface slightly, add docker_helper tests. * Add basic type for map function * Fix runImage so it always passes the right things * Fix spaces convention * Update test description * Fix location of container run test * Add fixtures to new testing area * Fix fixture file location * Update format of test expect * Fix os-specific pathing issue * Update packages/cli/test/unit/commands/container/run.unit.test.ts Co-authored-by: Justin Wilaby <jwilaby@gmail.com> * Add pullImage test * Clean up line breaks --------- Co-authored-by: Justin Wilaby <jwilaby@gmail.com>
* Add test:local that allows .only * Make test script naming consistent * Fix test:local
* refactor: initial access:index command migration * refactor: initial linting fixes and add types * refactor: migrate isTeamApp and getOwner util functions * refactor: reformat table construction * refactor: refactor collaborators array functions * refactor: more typing fixes * refactor: migrate access tests, stubs, and update table format * refactor: rename utils file * refactor: remove orgs-v5 access command and tests. Add integration test * refactor: remove integration test script from orgs-v5
* Convert orgs:access:update to oclif * Remove v5 access update command * Fix error expectation * Remove deprecated privileges alias, use stripansi
* Convert teams index command to oclif * Convert teams index test * Remove .only * Fix linting issue * Use heredoc to make indentation nicer
* refactor: initial migration and typing for members/index * refactor: refactor lib functions * refactor: additional typing fixes * refactor: refactor to use ux.table * refactor: migrate members:index tests and utils function fix * refactor: refactor to use required flag for team * refactor: do not show status column when there are no pending invites * refactor: remove v5 files and references
* Convert certs:index and some lib functions * Fix displaytable bugs, add unit test for certs:index. * remove .only * Replace any with more specific types * use heredoc for improved clarity * Have explicit types when sorting
* Update glob package version for CLI * Fix eslint warning * Moving tests for 'container:pull' to the right folder * Fixing path references on moved test file * Move command 'container:push' to CLI, OClif Core & TS * Convert unit tests for 'container:push' to CLI, OClif Core & TS * Fixing duplicated 'Error:' string on error outputs
* refactor: migrate members:set command to oclif/core * refactor: migrate members:set tests * refactor: remove orgs-v5 members:set files
* refactor: refactor orgs command and utils * refactor: migrate orgs tests * refactor: delete orgs/index and test from orgs-v5 * refactor: update class name
* refactor: migrate ogs:open command to oclif/core * refactor: add opening message and move open action to separate function * refactor: migrate orgs:open tests to oclif * refactor: remove v-5 orgs:open command and test files * refactor: update class name
* refactor: initial migration of access:remove * refactor: initial test refactor * refactor: test fix and update class name * refactor: remove orgs-v5 access:remove files * refactor: remove 'use strict' from stubs/delete
* refactor: migrate members:remove command to oclif/core * refactor: migrate tests for members:remove * fix: remove commented out code in test * refactor: remove members:remove command and test files from orgs-v5
* refactor: migrate members:add command and utils to oclif/core * refactor: refactor members:add tests and test utils * refactor: remove orgs-v5 members:add files * fix: update array.find to array.some and change require to import
…#2668) * Convert acm refresh command to oclif * Fix spacing lint issue * Remove v5 versions of certs auto refresh
…#2667) * Convert certs auto disable to oclif * Fix test and apply tsheredoc to clean up output * Make confirm flag hidden
* Convert certs:info to oclif * Convert endpoint stubs to types, convert shared_sni test * Fix testing data * Fix testing output for shared tests * Fix shared tests * Fix spelling typo * Change heredoc indents * Rework cert stub data
Reintroduce removing spaces Update commands output to include fig spec for now
* refactor: migrate access:add to oclif/core * refactor: migrate tests for access:add * refactor: remove commands:access files from orgs-v5 * refactor: remove access:index file from orgs-v5 (leftover from previous PR) * refactor: migrate command examples and flag description * fix: remove semi-colon
* Move command 'certs:auto:enable' to CLI * Removing unused lib file (migration completed) * Restoring lib file (migration was completed, but still referenced from another command) * Fixing expected outputs in tests.
* refactor: migrate container:release to oclif * refactor: migrate streamer helper and tests to typescript * refactor: migrate container:release tests to typescript * refactor: typescript and eslint fixes * refactor: fix first unit test * refactor: fix call to registry.heroku.com and reformat tests * refactor: add oclif static vars * refactor: remove container:release v5 command and related files * refactor: add authorization for docker registry call and rename class * refactor: remove the container-registry-v5 package and import * update yarn.lock
* Change to require either app or pipeline * Add test for requiring app or pipeline remove .only Remove tsheredoc import
…ags (#2909) * fix: update spaces:vpn commands to improve consistency in args and flags * fix: spaces:vpn:wait test fixes * fix: update args descriptions
…2910) * docs: add documentation on how to add config items for addons:create * fix: update commands-output
* refactor: remove outbound-rules commands due to endpoint deprecation * refactor: remove outbound-rules tests * refactor: remove ref to outbound-rules in cli package.json
…mmands (#2914) * Declaratively require pipeline or app across ci:config commands * Update test
* chore: remove alpha versions and reset changelogs * v9.0.0-beta.0
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
sbosio
approved these changes
Jul 16, 2024
pmukerji
reviewed
Jul 24, 2024
| $heroku addons:create heroku-redis --app my-app | ||
|
|
||
| Create an add-on resource with additional config items: | ||
| $heroku addons:create heroku-postgresql:standard-0 --app my-app -- --fork DATABASE |
There was a problem hiding this comment.
If I understood correctly, this is a new requirement to place additional configuration after --, right? Would the Heroku documentation be updated accordingly online? It seems docs like this one still refer to the old way: https://devcenter.heroku.com/articles/heroku-postgres-follower-databases#create-a-follower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constitutes a major restructuring of the CLI repository. Once it is merged:
After merging this PR we will release v9 of the CLI.