Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): enable backwards compatibility syntax for addons:create #2972

Merged
merged 11 commits into from
Aug 15, 2024

Conversation

zwhitfield3
Copy link
Contributor

@zwhitfield3 zwhitfield3 commented Aug 12, 2024

Description

This PR enables backwards compatible v8.x.x syntax for passing in positional arguments to the heroku addons:create command.

Testing

  1. Pull down branch
  2. yarn it up
  3. Confirm passing positional arguments using old v8.x.x syntax via
    ./bin/run addons:create -a heroku-cli-test-staging heroku-postgresql:private-0 --follow DATABASE
  4. Confirm that the addon successfully provisioned a follower database with the positional --follow flag
  5. Confirm that the deprecation warning is also visible like so:
 ›   Warning: You’re using a deprecated syntax with the [--follow] flag.
 ›   Add a '--' (end of options) separator before the flags you’re passing through.
 ›   For example: heroku addons:create -a heroku-cli-test-staging heroku-postgresql:private-0 -- --follow
 ›   See https://devcenter.heroku.com/changelog-items/2925 for more info.
  1. Once finished, remove any test provisioned addons to the aforementioned app used

@zwhitfield3
Copy link
Contributor Author

Waiting for CX approval so that heroku-cli-command can be bumped with the latest copy. Once changes are made to the upstream dependency, this PR will be good to merge.

@zwhitfield3 zwhitfield3 force-pushed the zw/enable-backwards-compatibility branch from 1ba917f to 894031d Compare August 13, 2024 23:23
@zwhitfield3 zwhitfield3 force-pushed the zw/enable-backwards-compatibility branch from 894031d to f864ba4 Compare August 13, 2024 23:28
@zwhitfield3 zwhitfield3 force-pushed the zw/enable-backwards-compatibility branch from aee51aa to 7d48294 Compare August 13, 2024 23:49
@zwhitfield3 zwhitfield3 force-pushed the zw/enable-backwards-compatibility branch from 7d48294 to 5268784 Compare August 14, 2024 00:00
@zwhitfield3 zwhitfield3 marked this pull request as ready for review August 14, 2024 00:21
@zwhitfield3 zwhitfield3 requested a review from a team as a code owner August 14, 2024 00:21
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwhitfield3 zwhitfield3 merged commit bdeeb09 into main Aug 15, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/enable-backwards-compatibility branch August 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants