fix: change type of value to string for log-min-duration #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
reviewed
Aug 14, 2024
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
k80bowman
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
eablack
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work item
Updates the type of the
valuearg for thepg:settings:auto-explain:log-min-settingscommand to string. It turns out that the PgSettingsCommand was expecting this to be a string anyway.This PR also updates the node version in the .tool-versions file to match what we list in our package.json.