Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis:cli): remove call to resolve ssh2 in bastionConnect function #2980

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

k80bowman
Copy link
Contributor

Work item

Description

Using the redis:cli command to connect to a redis instance using the private plan was failing. This PR implements the fix suggested in #2978.

Testing

  • Create an app inside of a private space and add a Heroku Redis instance on a private plan
  • Run heroku redis:cli redis_name -a app_name to see how the command fails
  • Pull down this branch and run yarn && yarn build
  • Run ./bin/run redis:cli redis_name -a app_name to see the command succeed

Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k80bowman k80bowman merged commit d11c18f into main Aug 16, 2024
8 checks passed
@k80bowman k80bowman deleted the k80/redis-cli-fix-2 branch August 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants