-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(run): arguments are incorrectly gathered leading to duplicates #2999
Conversation
3ee4796
to
5b837bf
Compare
5b837bf
to
20b19a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20b19a7
to
b39a726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commands are working now, thank you. 🎉
If we're not using the revertSortedArgs function any more, could you please remove it from the helpers file?
b39a726
to
fcd8a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Works great.
This PR fixes and issue with the
run
command where arguments after the--
which collide with the command flag names are duplicated leading to errors.e.g.
heroku run -e DOMAIN=test -- ruby -e 'puts ENV["ENV_KEY"]'
<-- '-e' is a collision with the command flag alias forenv
and is duplicated and sent to the Dyno by mistake.NOTE: Reverting the sorted args is no longer needed since a direct slice from the
process.argv
is performed. This operation has been removed.