Skip to content

Conversation

michaelmalave
Copy link
Contributor

@michaelmalave michaelmalave commented Sep 4, 2025

Description

This change updates the oclif (not to be confused with oclif/core) from 2.2.5 to 4.22.5 and resolves related critical dependencies while maintaining core functionality.

Testing

git checkout mm/fix-validated-domain
run the following commands

npm install && npm run build
HEROKU_HOST=heroku.com npm run example whoami
HEROKU_HOST=herokai.com npm run example whoami
HEROKU_HOST=fakeheroku.com npm run example whoami

Note errors should appear only for fakeheroku.com.

Screenshots (if applicable)

SOC2 Compliance

Gus Work Item: W-19527406 (Heroku internal)

@michaelmalave michaelmalave requested a review from a team as a code owner September 4, 2025 00:04
@michaelmalave michaelmalave changed the title fix: updating to include an alternate url when api.url.com does not exist fix: updating to include an alternate url when api.url.com does not exist | W-19527406 Sep 4, 2025
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests went smooth and changes look good to me.

@michaelmalave michaelmalave merged commit c075060 into main Sep 4, 2025
6 checks passed
@michaelmalave michaelmalave deleted the mm/fix-validated-domain branch September 4, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants