Add shared library version and other packaging changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install to libmcl.so rather than libmcl_dy.so as most distributions expect this - gitignore Makefile since it's generated by cmake - fix being able to override DOWNLOAD_SOURCE, it was always being set to ON before
|
I modify mcl to contain xbyak and cybozulib, so mcl can be built without them. |
|
It is still beneficial to commit to a stable API and provide a shared library version scheme that trackes ABI compatibility, but that's less urgent for dfinity and I'll file a separate issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course the version number 1.0.0 is only a suggestion, you can choose whatever you think is best - keeping in mind the semantics of how most systems expect it to go that I documented in the comments.