Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested options have invalid environment variable names #799

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jun 27, 2024

Nested options' environment variables contained dots which made them invalid.


Since there are no nested options yet, this fix should not appear in the changelog.

BEGIN_COMMIT_OVERRIDE
chore: nested options have invalid environment variable names
END_COMMIT_OVERRIDE

@phm07 phm07 added the bug label Jun 27, 2024
@phm07 phm07 self-assigned this Jun 27, 2024
@phm07 phm07 requested a review from a team as a code owner June 27, 2024 12:25
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.78%. Comparing base (c0cb16b) to head (db86e82).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/state/config/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   59.68%   59.78%   +0.10%     
==========================================
  Files         210      210              
  Lines        7639     7641       +2     
==========================================
+ Hits         4559     4568       +9     
+ Misses       2437     2430       -7     
  Partials      643      643              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit 186e182 into main Jun 27, 2024
5 checks passed
@phm07 phm07 deleted the fix-nested-option-env-var branch June 27, 2024 14:58
phm07 added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants