Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): only use numerical IDs for label auto-completion #865

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 6, 2024

We currently use the deprecated Get method here. Instead we can just parse an integer and use that as the ID, since you can only get or update labels on images you can modify (snapshots and backups), which only have numerical IDs and no names anyway.

@phm07 phm07 self-assigned this Sep 6, 2024
@phm07 phm07 requested a review from a team as a code owner September 6, 2024 15:56
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.47%. Comparing base (311642e) to head (a138da5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/hcapi2/image.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   61.49%   61.47%   -0.03%     
==========================================
  Files         238      238              
  Lines        8522     8525       +3     
==========================================
  Hits         5241     5241              
- Misses       2572     2575       +3     
  Partials      709      709              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit 1d10d92 into main Sep 9, 2024
5 checks passed
@phm07 phm07 deleted the image-label-key-suggestions branch September 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants