Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): remove node 6 and add node 12 #148

Merged
merged 1 commit into from
Sep 2, 2019
Merged

chore(ci): remove node 6 and add node 12 #148

merged 1 commit into from
Sep 2, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Sep 2, 2019

This PR need to be merged first, then rerun the appveyor job for #147

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.991% when pulling b8e95bd on ci-nodejs-version-6 into d6e0aa0 on master.

yoshinorin
yoshinorin approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yoshinorin yoshinorin merged commit db86c0b into master Sep 2, 2019
@yoshinorin yoshinorin deleted the ci-nodejs-version-6 branch September 2, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @yoshinorin