Update devDependencies #3277
Update devDependencies #3277
Conversation
* upgraded husky's script, because it has breaking change in v1.0.0
| "lint-staged": "^7.3.0", | ||
| "mocha": "^5.2.0", | ||
| "rewire": "^4.0.1", | ||
| "sinon": "^6.3.4" |
There was a problem hiding this comment.
IMO think the version difference is very large even for the sinon library alone, and it is not appropriate for the update target at once.
There was a problem hiding this comment.
Thanks!
At first about sinon.As you know This PR update sinon 4.x to 6.x.
sinon breaking changes in 5.x and 6.x is only removed spt.reset(). But this repositories doesn't using spy.reset().
Please see sinon migrate guide.
Second about rewire. rewire 4.0.0 has two breaking changes.
One is drop nodejs v4. This hexo repository already set node-engines higher 6.9.0, so we don't worry this breaking change.
Another one is potentially breaking, sorry I can not be say absolutely no problem, but unit test are passed. I think may be no problem.
So, I think we can bump up these dependencies to higher major version. But, if hexojs's committer require more carefully, I will change them major version up to minor version up.
There was a problem hiding this comment.
Thanks @yoshinorin for your quick reply!
I think there is no problem with the change itself.
Since the version difference is simply very large, I was worried about whether it is appropriate for PR unit.
It was a pleasure for you to leave the content of breaking change as a comment!
Including the reply to the review, I thought that I could merge. However, I do not know whether it is correct as a guideline for the hexojs project.
|
OK. I wait other hexo core member's review. |
|
I agree with @segayuu, but since the upgrades packages are all in dev. IMHO, I feel it is safe to merge as it passes the CI test. |
|
@segayuu @NoahDragon |
Some package are out of date.
This PR is update devDependencies and upgraded husky's script, because it has breaking change in v1.0.0