Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define global variable hexo #5242

Merged
merged 1 commit into from Aug 10, 2023

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented Jul 17, 2023

useful for plugin written in typescript or let IDE detecting it

What does it do?

Add global variable hexo. Since the release of TypeScript 3.4 there's a documented way to do it.
Useful for plugin written in typescript or let IDE typechecking detecting hexo.

Screenshots

script inside scripts folder automated detect global hexo without setting anything on IDE.
image
image

plugin using typescript.
image

demo improvement.
https://github.com/dimaslanjaka/hexo/tree/monorepo-v7/releases

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

useful for plugin written in typescript or let IDE detecting it
@github-actions
Copy link

How to test

git clone -b define-global-var https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

@dimaslanjaka
Copy link
Contributor Author

@SukkaW review pls

@coveralls
Copy link

Coverage Status

coverage: 99.529%. remained the same when pulling 70d0c09 on dimaslanjaka:define-global-var into b3b444d on hexojs:v7.0.0.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hexojs/core
Do you have any concerns? If not (or if no-reply for a while), I will merge this.

Thank you :)

@yoshinorin yoshinorin merged commit 24a7b61 into hexojs:v7.0.0 Aug 10, 2023
13 checks passed
@dimaslanjaka dimaslanjaka deleted the define-global-var branch August 12, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants